-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-3222 Move Session Replay obj-c interfaces directly to the target #1697
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 2752 Passed, 0 Skipped, 6m 52.13s Wall Time 🔻 Code Coverage Decreases vs Default Branch (7)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Moving the SR API from DatadogObjc
to DatadogSessionReplay
is a breaking-change, no? What is the rationale of doing it now and what is the mitigation we will offer?
@ncreated We discussed this with @maxep and it should work without a change on the customer side. It's following the v2 idea of moving all the obj-c api directly to targets and deprecating the obj-c wrapper. |
069b401
to
e1ddbc9
Compare
e1ddbc9
to
d2d153f
Compare
d2d153f
to
5047082
Compare
Getting this in snapshot tests:
Will try to resolve later. But sounds like it may require slightly different approach. |
5047082
to
bf02344
Compare
Datadog ReportBranch report: ✅ 0 Failed, 2897 Passed, 0 Skipped, 11m 8.86s Wall Time 🔻 Code Coverage Decreases vs Default Branch (11)
|
bf02344
to
479ca23
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 nice!
What and why?
Moves obj-c interfaces of Session Replay as described in the RFC
Review checklist
Custom CI job configuration (optional)
tools/