Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1836 feat(otel-tracer): send telemetry for Tracer API usage #1704

Merged

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Mar 4, 2024

What?

We want to track how many customers are using the OTel vs OT APIs

Schema update: DataDog/rum-events-format#190

How?

Send config telemetry events when tracer is get from a public API.

The initial plan to send the telemetry log when tracer is initialized which gives accurate data but for consistency reasons, we decided to use configuration telemetry. We may miss data for cases if the tracer is not initialized in first 5 seconds of the creation of configuration telemetry.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ganeshnj ganeshnj requested review from a team as code owners March 4, 2024 12:14
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we track metric instead of debug in both cases?

@ganeshnj
Copy link
Contributor Author

ganeshnj commented Mar 4, 2024

Shouldn't we track metric instead of debug in both cases?

When I was talking with @ncreated, recommendation was to use debug but happy to change whatever makes sense here. End goal is to have some tracking mechanism.

@ncreated
Copy link
Member

Shouldn't we track metric instead of debug in both cases?

When I was talking with @ncreated, recommendation was to use debug but happy to change whatever makes sense here. End goal is to have some tracking mechanism.

It doesn't seem to be a metric use case to me. Even with debug logs we can still visualise or generate metrics.

@ganeshnj ganeshnj force-pushed the ganeshnj/chore/telemetry-trace-api branch 2 times, most recently from 1198e51 to f0cab01 Compare March 11, 2024 21:23
Comment on lines 3570 to 4040
// Generated from https://github.com/DataDog/rum-events-format/tree/389581be98dcf8efbfcfe7bffaa32d53f960fb6f
// Generated from https://github.com/DataDog/rum-events-format/tree/b41d863ee439a22cef58fd2732e99b2cb8e4d89d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find b41d863 in rum-events-format repo 🤔 - we need a PR-approved change merged to rum-events-format/master

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataDog/rum-events-format#190

There are other unrelated issue due to branch being back.

@ganeshnj ganeshnj marked this pull request as draft March 12, 2024 12:51
@ganeshnj ganeshnj force-pushed the ganeshnj/chore/telemetry-trace-api branch from f0cab01 to ec37f70 Compare March 12, 2024 13:20
@ganeshnj ganeshnj marked this pull request as ready for review March 12, 2024 13:21
@ganeshnj ganeshnj marked this pull request as draft March 12, 2024 13:31
@ganeshnj ganeshnj force-pushed the ganeshnj/chore/telemetry-trace-api branch from 3c553a2 to 4ea1bb6 Compare March 12, 2024 13:46
@ganeshnj ganeshnj marked this pull request as ready for review March 12, 2024 14:08
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

@ganeshnj ganeshnj merged commit b7cfa4f into ganeshnj/feat/otel-tracer Mar 13, 2024
8 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/chore/telemetry-trace-api branch March 13, 2024 13:02
@ncreated ncreated mentioned this pull request May 31, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants