Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-3291 Privacy Manifest - describe data use #1724

Merged
merged 4 commits into from
Mar 15, 2024
Merged

RUM-3291 Privacy Manifest - describe data use #1724

merged 4 commits into from
Mar 15, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Mar 13, 2024 •
edited
Loading

What and why?

Add data use decription in Privacy Manifests for:

  • DatadogCore
  • DatadogRUM
  • DatadogCrashReporting

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 13, 2024 •
edited
Loading

Datadog Report

Branch report: maxep/RUM-3291/privacy-manifest
Commit report: 2847390
Test service: dd-sdk-ios

✅ 0 Failed, 2816 Passed, 0 Skipped, 11m 30.3s Wall Time
🔻 Test Sessions change in coverage: 2 decreased, 4 increased, 8 no change

🔻 Code Coverage Decreases vs Default Branch (2)

  • test DatadogRUMTests iOS 79.02% (-0.09%) - Details
  • test DatadogTraceTests tvOS 49.94% (-0.01%) - Details

@maxep maxep force-pushed the maxep/RUM-3291/privacy-manifest branch from 33482b8 to 2847390 Compare March 13, 2024 13:01
@maxep maxep changed the title RUM3291 Privacy Manifest - describing data use RUM3291 Privacy Manifest - describe data use Mar 13, 2024
@maxep maxep marked this pull request as ready for review March 13, 2024 15:13
@maxep maxep requested review from a team as code owners March 13, 2024 15:13
@maxep maxep changed the title RUM3291 Privacy Manifest - describe data use RUM-3291 Privacy Manifest - describe data use Mar 13, 2024
maciejburda
maciejburda previously approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! ✌️

@maxep maxep force-pushed the maxep/RUM-3291/privacy-manifest branch from ceec9c1 to 1cad71f Compare March 15, 2024 09:33
@maxep maxep force-pushed the maxep/RUM-3291/privacy-manifest branch from 1cad71f to ace2907 Compare March 15, 2024 09:39
@maxep maxep requested a review from maciejburda March 15, 2024 09:40
maciejburda
maciejburda approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxep maxep merged commit 1f767ef into develop Mar 15, 2024
18 checks passed
@maxep maxep deleted the maxep/RUM-3291/privacy-manifest branch March 15, 2024 10:39
This was referenced Mar 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxep @maciejburda