Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3134 fix: SR test on iOS 17+ #1785

Merged
merged 1 commit into from
Apr 26, 2024
Merged

RUM-3134 fix: SR test on iOS 17+ #1785

merged 1 commit into from
Apr 26, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Apr 19, 2024

How?

Observation: getting the view's controller using the next responder requires the view-controller to be in a UIWindow.

Therefor, the test is modified to create the view tree in a window.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep self-assigned this Apr 19, 2024
@maxep maxep requested review from a team as code owners April 19, 2024 14:42
@maxep maxep force-pushed the maxep/RUM-3134/fix-sr-test branch from 24fe3d4 to f768267 Compare April 19, 2024 16:00
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 19, 2024

Datadog Report

Branch report: maxep/RUM-3134/fix-sr-test
Commit report: f768267
Test service: dd-sdk-ios

✅ 0 Failed, 3006 Passed, 0 Skipped, 10m 38.28s Wall Time
🔻 Test Sessions change in coverage: 3 decreased, 8 increased, 3 no change

🔻 Code Coverage Decreases vs Default Branch (3)

  • test DatadogRUMTests tvOS 80.85% (-0.18%) - Details
  • test DatadogCoreTests iOS 73.42% (-0.08%) - Details
  • test DatadogRUMTests iOS 80.64% (-0.05%) - Details

@maxep maxep merged commit 066c2f9 into develop Apr 26, 2024
8 checks passed
@maxep maxep deleted the maxep/RUM-3134/fix-sr-test branch April 26, 2024 12:32
@ganeshnj ganeshnj mentioned this pull request May 2, 2024
8 tasks
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants