RUM-3470 feat: Head-based sampling #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atic distributed tracing
…mpling-part1 RUM-3470 feat: Head-based sampling for local and (automatic) distributed tracing
Datadog ReportBranch report: ✅ 0 Failed, 3032 Passed, 0 Skipped, 11m 35.24s Wall Time 🔻 Code Coverage Decreases vs Default Branch (9)
|
8 tasks
…mpling-part2-with-new-init RUM-3470 feat: Head-based sampling for manual distributed tracing
ganeshnj
previously approved these changes
Apr 26, 2024
* develop: (43 commits) Update apiSurface files for Swift and Objective-C Update dependency-manager-tests/spm/Shared/DatadogSetup.swift Bumped version to 2.10.0 Update CHANGELOG for 2.10.0 release Revert nil interface Revert "Lock identifier assertion to default device" Lock identifier assertion to default device Tests for store update Fix lint Update store version Fix color SR identifier PR fixes Synchronize access to Datadog.verbosityLevel fixing issue #1549 RUM-3134 attach vc to window Fix deployment target on SPM project Apply suggestions from code review apply cr suggestions Documentation update PR fixes Remove failing test ...
ganeshnj
approved these changes
Apr 26, 2024
maxep
approved these changes
Apr 26, 2024
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 Merging the head-based sampling feature.
Solves #1713
With head-based sampling, the decision to keep or drop the trace is determined from the first span of the trace, the head, when the trace is created. This is not compatible with how local spans sampling used to work before, where each span was sampled individually, without considering sampling of the parent span.
In practise, this PR will change the result of following usages:
How?
CHANGELOG.mdupdate + merge of following work (no code review required):Review checklist
Custom CI job configuration (optional)
tools/