Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isInitialized and stopInstance methods to ObjC API #1800

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Apr 26, 2024

What and why?

This PR adds isInitialized and stopInstance methods to ObjC API which were missing, but exist in Swift API.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@0xnm 0xnm requested review from a team as code owners April 26, 2024 12:07
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Apr 26, 2024

Datadog Report

Branch report: nogorodnikov/add-stopinstance-and-isinitialized-to-objc-api
Commit report: 169d46f
Test service: dd-sdk-ios

✅ 0 Failed, 2767 Passed, 0 Skipped, 5m 40.04s Wall Time
🔻 Test Sessions change in coverage: 8 decreased, 4 increased, 1 no change

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • test DatadogCoreTests tvOS 79.32% (-0.3%) - Details
  • test DatadogLogsTests tvOS 45.09% (-0.28%) - Details
  • test DatadogLogsTests iOS 45.04% (-0.28%) - Details
  • test DatadogCrashReportingTests tvOS 27.72% (-0.18%) - Details
  • test DatadogCrashReportingTests iOS 27.71% (-0.18%) - Details

maxep
maxep previously approved these changes Apr 29, 2024
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@0xnm 0xnm force-pushed the nogorodnikov/add-addExtraUserInfo-to-objc branch from 2cb116d to 30d8fdc Compare April 29, 2024 09:17
@0xnm 0xnm force-pushed the nogorodnikov/add-stopinstance-and-isinitialized-to-objc-api branch from 7637abc to 169d46f Compare April 29, 2024 09:31
@0xnm 0xnm changed the base branch from nogorodnikov/add-addExtraUserInfo-to-objc to develop April 29, 2024 09:42
@0xnm 0xnm dismissed maxep’s stale review April 29, 2024 09:42

The base branch was changed.

@0xnm 0xnm merged commit 81e8103 into develop Apr 29, 2024
6 checks passed
@maxep maxep deleted the nogorodnikov/add-stopinstance-and-isinitialized-to-objc-api branch April 29, 2024 11:33
@ganeshnj ganeshnj mentioned this pull request May 2, 2024
8 tasks
This was referenced May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants