Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIVIS-9813] fix for test sdk integration #1833

Closed
wants to merge 2 commits into from
Closed

[CIVIS-9813] fix for test sdk integration #1833

wants to merge 2 commits into from

Conversation

ypopovych
Copy link

What and why?

Swift testing library is using MachPorts to communicate with this library. They are unique for OS kernel, so each process should have a unique name for them. Right now we are using hardcoded names, so two running test processes will fail.

How?

Testing library sets CI_VISIBILITY_MESSAGE_CHANNEL_UUID variable which is used for name generation for MachPorts.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ypopovych ypopovych requested review from a team as code owners May 14, 2024 09:59
@ncreated
Copy link
Member

@ypopovych Thanks for this contribution. I had to rebase it onto recent develop after we bumped the linter version (I also fixed lint problems). I'll close this one in favour of #1852.

As DD employee please 🙏 open a PRs directly to our repo instead of using fork - it's much less hassle in case of assistance for CI failures 🙂.

@ncreated ncreated closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants