Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🧰 This PR updates
rum-model-generator
so we can generate models from latest commits in rum-events-format.How?
There were two breaking commits in
rum-events-format
:✨RUM-4029 bootstrap telemetry usage schema adding a whole new root-level schema for "usage telemetry". It requires generating polymorphic Swift types at nested level which isn't yet supported. Generation fails with:
Because we don't yet leverage this feature, this PR explicitly ignores this subschema. The actual work to add this support is moved to
RUM-4571
.RUM-1844: Add device and os info to telemetry events introducing
telemetry.os
andtelemetry.device
objects. Because definition of these objects is different (although similar) from*.os
and*.device
in regular RUM events it was raising the exception on being unable to share model definition. To avoid this,telemetry.os
andtelemetry.device
types are shared using different name.Review checklist
Custom CI job configuration (optional)
tools/