Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix generating rum models #1855

Merged
merged 2 commits into from
May 21, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented May 21, 2024

What and why?

🧰 This PR updates rum-model-generator so we can generate models from latest commits in rum-events-format.

How?

There were two breaking commits in rum-events-format:

RUM-4029 bootstrap telemetry usage schema adding a whole new root-level schema for "usage telemetry". It requires generating polymorphic Swift types at nested level which isn't yet supported. Generation fails with:

🚧 Unimplemented: Building `SwiftAssociatedTypeEnum` case label for JSONObject is not supported

Because we don't yet leverage this feature, this PR explicitly ignores this subschema. The actual work to add this support is moved to RUM-4571.

RUM-1844: Add device and os info to telemetry events introducing telemetry.os and telemetry.device objects. Because definition of these objects is different (although similar) from *.os and *.device in regular RUM events it was raising the exception on being unable to share model definition. To avoid this, telemetry.os and telemetry.device types are shared using different name.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this May 21, 2024
@ncreated ncreated marked this pull request as ready for review May 21, 2024 09:46
@ncreated ncreated requested review from a team as code owners May 21, 2024 09:46
@ncreated ncreated merged commit 6a83417 into develop May 21, 2024
6 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-generating-rum-models branch May 21, 2024 16:53
This was referenced May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants