Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix dogfooding automation #1869

Merged
merged 2 commits into from
May 29, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented May 29, 2024

What and why?

🧰 πŸ’Š Fixes the recent problem with dogfooding script:

❌ Failed to dogfood: 'repositoryURL'
------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/vagrant/git/tools/distribution/dogfood.py", line 119, in <module>
    dogfood(
  File "/Users/vagrant/git/tools/distribution/dogfood.py", line 76, in dogfood
    repository_url=dependency['repositoryURL'],
                   ~~~~~~~~~~^^^^^^^^^^^^^^^^^
KeyError: 'repositoryURL'

How?

The dependency['repositoryURL'] is not valid syntax for version 2 and version 3 Package.resolved. Updating the key name to location fixes the problem.

🎁 As a bonus, I added a basic smoke test for dogfooding automation. By running it with dry-run mode we ensure that it works fine after any change to dogfooding.py.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this May 29, 2024
@ncreated ncreated marked this pull request as ready for review May 29, 2024 15:28
@ncreated ncreated requested review from a team as code owners May 29, 2024 15:28
@ncreated ncreated merged commit 2448074 into develop May 29, 2024
2 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-dogfooding-script2 branch May 29, 2024 15:41
This was referenced May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants