Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Disable flaky OTelSpan.testSetActive_givenParentSpan() test #1881

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jun 4, 2024

What and why?

📦 ❄️ This PR disables flaky OTel test (testSetActive_givenParentSpan()). This is to address recent CI failures.

How?

Disabled failed test and created RUM-4795 to re-enable it when possible.

I also revamped the whole OTelSpanTests suite to take dependency on FeatureScope rather than core mock. This is to address mid-term goals from #1744 - having less and simpler dependency in tests so they run faster, more stable and are easier to debug.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this Jun 4, 2024
@ncreated ncreated force-pushed the ncreated/chore/disable-flaky-OTel-tests branch from 5dff5bc to 57f8b80 Compare June 4, 2024 15:09
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2024

Datadog Report

Branch report: ncreated/chore/disable-flaky-OTel-tests
Commit report: 1d047f5
Test service: dd-sdk-ios

✅ 0 Failed, 3235 Passed, 0 Skipped, 2m 25.84s Total Time
🔻 Test Sessions change in coverage: 9 decreased, 3 increased, 1 no change

🔻 Code Coverage Decreases vs Default Branch (9)

This report shows up to 5 code coverage decreases.

  • test DatadogTraceTests iOS 54.69% (-0.6%) - Details
  • test DatadogTraceTests tvOS 55.22% (-0.3%) - Details
  • test DatadogRUMTests iOS 81.25% (-0.21%) - Details
  • test DatadogCrashReportingTests tvOS 27.32% (-0.07%) - Details
  • test DatadogCrashReportingTests iOS 27.29% (-0.07%) - Details

@ncreated ncreated marked this pull request as ready for review June 4, 2024 15:30
@ncreated ncreated requested review from a team as code owners June 4, 2024 15:30
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ncreated ncreated merged commit d924662 into develop Jun 5, 2024
8 checks passed
@ncreated ncreated deleted the ncreated/chore/disable-flaky-OTel-tests branch June 5, 2024 09:03
@@ -230,6 +230,9 @@
<Test
Identifier = "DatadogTracer_SamplingTests/testWhenRootSpanIsSampled_thenAllChildSpansMustBeSampledTheSameWay()">
</Test>
<Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do for tvOS too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants