Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SR Test Flakiness #1882

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: SR Test Flakiness #1882

merged 1 commit into from
Jun 5, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Jun 4, 2024

What and why?

The testWhenViewIsOfExpectedType uses a fuzzy fixture, following #1864 we now ignore invisible navigation bar so we need to remove the .invisible attribute from fixture as well.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested review from a team as code owners June 4, 2024 14:58
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 4, 2024

Datadog Report

Branch report: maxep/fix-flakiness
Commit report: b12c9fb
Test service: dd-sdk-ios

✅ 0 Failed, 3236 Passed, 0 Skipped, 2m 19.47s Total Time
🔻 Test Sessions change in coverage: 8 decreased, 4 increased, 1 no change

🔻 Code Coverage Decreases vs Default Branch (8)

This report shows up to 5 code coverage decreases.

  • test DatadogRUMTests iOS 81.22% (-0.23%) - Details
  • test DatadogCrashReportingTests iOS 27.27% (-0.09%) - Details
  • test DatadogCrashReportingTests tvOS 27.32% (-0.07%) - Details
  • test DatadogLogsTests tvOS 46.1% (-0.06%) - Details
  • test DatadogLogsTests iOS 46.05% (-0.06%) - Details

@maxep maxep merged commit 5887cee into develop Jun 5, 2024
8 checks passed
@maxep maxep deleted the maxep/fix-flakiness branch June 5, 2024 06:40
@maciejburda maciejburda mentioned this pull request Jun 12, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants