Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2442 [S8S] Emit _dd.session.id and _dd.application.id on view change #1893

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Jun 11, 2024

What and why?

Same as DataDog/dd-sdk-android#1813

Emit the Application and Session ID with the view so S8S can retrieve them in the device logs.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maxep maxep requested review from a team as code owners June 11, 2024 08:49
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 11, 2024

Datadog Report

Branch report: maxep/s8s-rum-context
Commit report: ac6052d
Test service: dd-sdk-ios

✅ 0 Failed, 2981 Passed, 0 Skipped, 2m 13.22s Total Time
🔻 Test Sessions change in coverage: 3 decreased, 3 increased, 7 no change

🔻 Code Coverage Decreases vs Default Branch (3)

  • test DatadogTraceTests tvOS 54.94% (-0.18%) - Details
  • test DatadogTraceTests iOS 54.63% (-0.03%) - Details
  • test DatadogCoreTests iOS 73.93% (-0.03%) - Details

Copy link
Member

@vbarbaresi vbarbaresi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -43,11 +43,6 @@ internal class RUMApplicationScope: RUMScope, RUMContextProvider {
activeViewName: nil,
activeUserActionID: nil
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/question I know that's how Android did it, but could it be useful to not delete these, and just add the new logs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logs in the view scope will be sufficient for S8S to correlate with the session, no need to keep other prints 👍

@maxep maxep merged commit cbda76b into develop Jun 11, 2024
6 checks passed
@maxep maxep deleted the maxep/s8s-rum-context branch June 11, 2024 09:48
This was referenced Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants