Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix complication issues on Xcode 16 #1898

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

maciejburda
Copy link
Member

@maciejburda maciejburda commented Jun 12, 2024

What and why?

Resolve compilation issue reported in #1892

Issue is that in new version of Xcode, the copied signature function:
open func beginBackgroundTask(expirationHandler handler: (() -> Void)? = nil) -> UIBackgroundTaskIdentifier is enriched with @MainActor resulting in a conflict.

This PR renames those functions signatures and adds extension that calls corresponding UIApplication functions.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@maciejburda maciejburda marked this pull request as ready for review June 12, 2024 09:32
@maciejburda maciejburda requested review from a team as code owners June 12, 2024 09:32
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 12, 2024

Datadog Report

Branch report: maciey/fix-xcode16-compliation-issues
Commit report: 3358707
Test service: dd-sdk-ios

✅ 0 Failed, 3058 Passed, 0 Skipped, 2m 21.84s Total Time
🔻 Test Sessions change in coverage: 7 decreased, 6 increased

🔻 Code Coverage Decreases vs Default Branch (7)

This report shows up to 5 code coverage decreases.

  • test DatadogTraceTests tvOS 54.85% (-0.28%) - Details
  • test DatadogCrashReportingTests tvOS 27.21% (-0.12%) - Details
  • test DatadogCrashReportingTests iOS 27.17% (-0.1%) - Details
  • test DatadogLogsTests tvOS 46.03% (-0.07%) - Details
  • test DatadogLogsTests iOS 45.97% (-0.06%) - Details

@maciejburda
Copy link
Member Author

Related to #1896 and #1895

I think it's better to change the protocol and be more explicit.

Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maciejburda maciejburda merged commit dc16eac into develop Jun 12, 2024
6 checks passed
@maciejburda maciejburda deleted the maciey/fix-xcode16-compliation-issues branch June 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants