Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4829 Upgrade CI stack to Xcode 15 #1901

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jun 12, 2024

What and why?

📦 This PR updates the repo so we can run Xcode 15 on CI.

It follows earlier #1891 where we dropped iOS and tvOS 11.0 deployment targets (no longer available in Xcode 15).

How?

3 main changes:

Testing:

  • I ran each stage (unit tests, SR snapshots, integration tests, smoke tests, tools) in isolation using temporary Xcode 15 stack. All worked fine ✅ ✅ ✅ ✅ ✅.
  • I don't expect any impact on release automation because smoke tests for all dependency managers worked fine (including XCFrameworks build).

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated self-assigned this Jun 12, 2024
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Jun 12, 2024

Datadog Report

Branch report: ncreated/RUM-4829/upgrade-ci-to-xcode15
Commit report: 39fe41d
Test service: dd-sdk-ios

✅ 0 Failed, 3303 Passed, 0 Skipped, 3m 6.86s Total Time

@ncreated ncreated force-pushed the ncreated/RUM-4829/upgrade-ci-to-xcode15 branch 7 times, most recently from 0ca6672 to e1bc9b0 Compare June 12, 2024 16:05
@ncreated ncreated force-pushed the ncreated/RUM-4829/upgrade-ci-to-xcode15 branch from e1bc9b0 to 54edf6d Compare June 12, 2024 16:08
@ncreated ncreated marked this pull request as ready for review June 12, 2024 16:09
@ncreated ncreated requested review from a team as code owners June 12, 2024 16:09
Copy link
Member

@mariedm mariedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🚀

Copy link
Contributor

@ganeshnj ganeshnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the minimum version of the iOS simulator we are testing on in CI?

@@ -1,4 +1,4 @@
// swift-tools-version: 5.7.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -2,6 +2,9 @@
IPHONEOS_DEPLOYMENT_TARGET=12.0
TVOS_DEPLOYMENT_TARGET=12.0

// Minimum supported Swift version
SWIFT_VERSION=5.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@ncreated
Copy link
Member Author

What is the minimum version of the iOS simulator we are testing on in CI?

@ganeshnj we use iPhone 11,OS=latest (see in Bitrise.yml). Effectively it means iOS 17.5 for the current stack. We can look into distinguishing "high" and "low" simulators once we move to GitLab.

@ncreated ncreated merged commit c47cfc0 into develop Jun 13, 2024
20 checks passed
@ncreated ncreated deleted the ncreated/RUM-4829/upgrade-ci-to-xcode15 branch June 13, 2024 08:40
@maciejburda maciejburda mentioned this pull request Jun 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants