-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-4829 Upgrade CI stack to Xcode 15 #1901
Conversation
rather than overriding it in Xcode project
Datadog ReportBranch report: ✅ 0 Failed, 3303 Passed, 0 Skipped, 3m 6.86s Total Time |
0ca6672
to
e1bc9b0
Compare
e1bc9b0
to
54edf6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the minimum version of the iOS simulator we are testing on in CI?
@@ -1,4 +1,4 @@ | |||
// swift-tools-version: 5.7.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
@@ -2,6 +2,9 @@ | |||
IPHONEOS_DEPLOYMENT_TARGET=12.0 | |||
TVOS_DEPLOYMENT_TARGET=12.0 | |||
|
|||
// Minimum supported Swift version | |||
SWIFT_VERSION=5.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
@ganeshnj we use |
What and why?
📦 This PR updates the repo so we can run Xcode 15 on CI.
It follows earlier #1891 where we dropped iOS and tvOS 11.0 deployment targets (no longer available in Xcode 15).
How?
3 main changes:
Base.xcconfig
(following the pattern from RUM-4829 Bump iOS and tvOS deployment target to12.0
#1891).Package.swift
and CP podspecs are updated accordingly.Testing:
Review checklist
Custom CI job configuration (optional)
tools/