Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUM-1660 chore: Enhance RUM session debugging in Example app #1902

Merged
merged 1 commit into from
Jun 13, 2024
Merged

RUM-1660 chore: Enhance RUM session debugging in Example app #1902

merged 1 commit into from
Jun 13, 2024

Conversation

ncreated
Copy link
Member

What and why?

📦 This PR adds convenience to the RUM Session Debugging page in Example app.

It comes handy in debugging RUM sessions, notably for the "Session Ended" telemetry added in #1866.

Re-opening #1894 which was closed by GH 🤔💭.

How?

3 changes:

  • added a button to manually end the session through stopSession() API,
  • added extra label displaying the current session ID,
  • overal revamp to make more space for rendering session state at the bottom.
Before After
before after

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Core, RUM, Trace, Logs, CR and WVT
  • Run unit tests for Session Replay
  • Run integration tests
  • Run smoke tests
  • Run tests for tools/

@ncreated ncreated requested review from a team as code owners June 12, 2024 16:30
@ncreated ncreated self-assigned this Jun 12, 2024
@ncreated
RUM-1660 Enhance RUM session debugging
b1f64d9 
by adding more options to Example app
@ncreated ncreated force-pushed the ncreated/RUM-1660/enhance-rum-session-debugging branch from eb70c4e to b1f64d9 Compare June 13, 2024 08:50
mariedm
mariedm approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@mariedm mariedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just found out about this debug view 👌

@ncreated ncreated merged commit 888d39f into develop Jun 13, 2024
2 checks passed
@ncreated ncreated deleted the ncreated/RUM-1660/enhance-rum-session-debugging branch June 13, 2024 10:44
@maciejburda maciejburda mentioned this pull request Jun 13, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariedm mariedm mariedm approved these changes

@maciejburda maciejburda maciejburda approved these changes

Assignees

@ncreated ncreated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncreated @maciejburda @mariedm