-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-4591 chore: Add diagnostic attributes to "RUM Session Ended" telemetry #1904
RUM-4591 chore: Add diagnostic attributes to "RUM Session Ended" telemetry #1904
Conversation
- if background events tracking is enabled - off-view events - has replay - NTP offset
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 1490 Passed, 0 Skipped, 1m 21.09s Total Time ❌ Failed Tests (1)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more fundamental question on choice of type in the PR. The changes looks good.
to avoid memory footprint on struct mutations
What and why?
📦 🔭 According to the spec (internal), this PR adds "diagnostic attributes" to "RUM Session Ended" telemetry.
This is a follow-up on #1866 where we implemented a handset of "quality attributes".
How?
The list of added attributes:
rse.has_background_events_tracking_enabled
Indicates whether tracking of background events was enabled in the RUM configuration.
rse.views_count.by_instrumentation
Holds the map of instrumentation type to the number of distinct views (view UUIDs) tracked through it (
manual
|swiftui
|uikit
).rse.views_count.with_has_replay
The number of views with
has_replay == true
.rse.ntp_offset
The NTP offset at the beginning and end of the session.
rse.no_view_events_count
The number of events (
actions
|resources
|errors
|long_tasks
) dropped because there was no active view at the time they occurred.Review checklist
Custom CI job configuration (optional)
tools/