Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix SPM build and add scripts to check locally #1914

Merged
merged 2 commits into from
Jun 20, 2024
Merged

chore: fix SPM build and add scripts to check locally #1914

merged 2 commits into from
Jun 20, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 20, 2024 •
edited
Loading

What and why?

https://swiftpackageindex.com/DataDog/dd-sdk-ios/builds

How?

  • fix the build issues
  • added ability to build the SDK all from Package.swift file
  • We first delete the workspace file, in order to force SPM build

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay
  • Run smoke tests
  • Run tests for tools/

@ganeshnj ganeshnj requested review from a team as code owners June 20, 2024 08:55
ncreated
ncreated previously approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tools/spm.sh Show resolved Hide resolved
maciejburda
maciejburda approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@maciejburda maciejburda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ganeshnj ganeshnj merged commit 85f4abe into develop Jun 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

@maxep maxep maxep approved these changes

@ncreated ncreated ncreated left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ganeshnj @ncreated @maxep @maciejburda