RUM-5004 Record resources while processing snapshots #1919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariedm
previously approved these changes
Jun 26, 2024
...s/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UIImageViewRecorder.swift
Outdated
Show resolved
Hide resolved
...s/Recorder/ViewTreeSnapshotProducer/ViewTreeSnapshot/NodeRecorders/UIImageViewRecorder.swift
Outdated
Show resolved
Hide resolved
DatadogSessionReplay/Tests/Processor/SnapshotProcessorTests.swift
Outdated
Show resolved
Hide resolved
maxep
force-pushed
the
maxep/RUM-5004/revamp-resource-recording
branch
from
1fb8b28 to
97f548d
Compare
Co-Authored-By: Marie Denis <29802155+mariedm@users.noreply.github.com>
maxep
force-pushed
the
maxep/RUM-5004/revamp-resource-recording
branch
from
97f548d to
6cfaa79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Previously, resources where created while recording the views. But in SwiftUI, we will only be able to create resources at the processing phase. To accommodate this, resources will now be created when building the wireframes and written by the snapshot processor.
How?
The
SnapshotProcessornow holds a reference to aResourceProcessor, and theSessionReplayWireframesBuilderwill keep track of resources while building the wireframes. TheSnapshotProcessorwill pass all collected resources to itsResourceProcessorinstance.Note:
The
ResourceProcessorand theResourcesWriterare doing the same checks to deduplicate images, but on different threads. This needs a refactoring as well, but it's outside the scope of this PR.Review checklist
Custom CI job configuration (optional)
tools/