Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4149 [SR] Add suport for UIProgressView #1923

Merged
merged 9 commits into from
Jun 27, 2024
Merged

Conversation

mariedm
Copy link
Member

@mariedm mariedm commented Jun 24, 2024

What and why?

Adding UIProgressView support to Session Replay.

How?

This PR:

  • creates a new recorder for progress views
  • removes progress view from unsupported views
  • adds corresponding unit + snapshot tests

image

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay
  • Run smoke tests
  • Run tests for tools/

@mariedm mariedm force-pushed the mariedm/RUM-4149 branch from 85880e5 to 5b74591 Compare June 24, 2024 16:25
@mariedm mariedm force-pushed the mariedm/RUM-4149 branch from 5b74591 to 613c818 Compare June 24, 2024 16:31
@mariedm mariedm marked this pull request as ready for review June 25, 2024 13:20
@mariedm mariedm requested review from a team as code owners June 25, 2024 13:20
maxep
maxep previously approved these changes Jun 25, 2024
Copy link
Member

@maxep maxep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, well done!

Co-authored-by: Maxime Epain <maxime.epain@datadoghq.com>
@mariedm mariedm merged commit 725e59b into develop Jun 27, 2024
15 checks passed
@mariedm mariedm deleted the mariedm/RUM-4149 branch June 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants