Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use otel-swift fork that only has APIs #1930

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jun 28, 2024

What and why?

Related DataDog/opentelemetry-swift-packages#17

We are not sure when the dependency issue will be resolved at the root level.

How?

Take a dependency on the forked version of otel-swift that has only APIs.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

Package.swift Show resolved Hide resolved
@ganeshnj ganeshnj marked this pull request as ready for review July 1, 2024 09:21
@ganeshnj ganeshnj requested review from a team as code owners July 1, 2024 09:21
@ganeshnj ganeshnj merged commit 13c7608 into develop Jul 3, 2024
14 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/chore/do-not-use-otel-repo branch July 3, 2024 08:29
@maciejburda maciejburda mentioned this pull request Jul 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants