Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: send Watchdog Termination once only #1932

Merged
merged 1 commit into from
Jul 1, 2024
Merged

fix: send Watchdog Termination once only #1932

merged 1 commit into from
Jul 1, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jul 1, 2024

What and why?

We added the logic to send only view updated under the 4h threshold but didn't remove the original logic. Hence, WT are reported 2 times.

How?

remove the redundant WT event writing.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

@ganeshnj ganeshnj requested review from a team as code owners July 1, 2024 13:11
@ganeshnj ganeshnj merged commit 1a61f0f into develop Jul 1, 2024
14 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/fix/duplicate-wt-event branch July 1, 2024 13:53
@maciejburda maciejburda mentioned this pull request Jul 10, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariedm mariedm mariedm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganeshnj @mariedm