RUM-4150 [SR] Add Activity Indicator Recorder #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feat/RUM-4150-activity-indicator-recorder
…feat/RUM-4150-activity-indicator-recorder
mariedm
commented
Jul 2, 2024
| @@ -46,6 +46,8 @@ internal class SnapshotTestCase: XCTestCase { | |||
| function: StaticString = #function | |||
| ) throws { | |||
| show(fixture: fixture) | |||
| // Give time for the view to appear and lay out properly | |||
| wait(seconds: 0.2) | |||
There was a problem hiding this comment.
I had to add this, otherwise the snapshot test suite is failing after adding a new test for the activity indicator recorder. This is a temporary workaround for a known issue.
maxep
reviewed
Jul 3, 2024
There was a problem hiding this comment.
I don't think these tests are relevant anymore, it can be removed IMO.
There was a problem hiding this comment.
I left the last one which still seems useful to test part of the UnsupportedViewRecorder logic with specific ViewControllerType.
Comment on lines
41
to
43
| shouldRecordImagePredicate: { imageView in | ||
| return imageView.image == nil ? false : true | ||
| } |
There was a problem hiding this comment.
/nit
Suggested change
| shouldRecordImagePredicate: { imageView in | |
| return imageView.image == nil ? false : true | |
| } | |
| shouldRecordImagePredicate: { $0.image != nil } |
/question Are we forcing recording of the image because it is not considered as context image?
…feat/RUM-4150-activity-indicator-recorder
maxep
approved these changes
Jul 3, 2024
maxep
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Adding support for
UIActivityIndicatorin Session Replay.How?
This PR:
Review checklist
Custom CI job configuration (optional)