Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pin OpenTelemetryApi version in Cartfile #1935

Merged

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jul 2, 2024

What and why?

📦 This is to ensure that upstream projects resolve the right version of OpenTelemetryApi. This includes not only customer projects, but also carthage Smoke Tests in our repo.

How?

Pinned the version of OpenTelemetryApi in Cartfile

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

@ncreated ncreated marked this pull request as ready for review July 2, 2024 12:41
@ncreated ncreated requested review from a team as code owners July 2, 2024 12:41
@ncreated ncreated self-assigned this Jul 2, 2024
@ncreated ncreated merged commit c92c8b6 into develop Jul 2, 2024
14 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-otel-dep-in-carthage-smoke-tests branch July 2, 2024 13:39
@maciejburda maciejburda mentioned this pull request Jul 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants