Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter issue for swiftlint 0.55.1 #1936

Merged

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Jul 2, 2024

What and why?

📦 Fixing lint problem for swiftlint 0.55.1.

It passed CI because we use swiftlint 0.53.0 in our runners. This fix prepares develop branch for linter upgrade on CI.

How?

The @_exported import introduced for SR configuration was missing linter opt-out. It is now added the same way as it was done for in RUM and Trace configuration.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

it passed CI because we use 0.53.0 there
@ncreated ncreated requested review from a team as code owners July 2, 2024 13:18
Copy link
Member

@mariedm mariedm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 🔨

@ncreated ncreated merged commit 34a3978 into develop Jul 3, 2024
15 checks passed
@ncreated ncreated deleted the ncreated/chore/fix-lint-issue-for-swiftlint-0.55.1 branch July 3, 2024 06:02
@maciejburda maciejburda mentioned this pull request Jul 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants