Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Watchdog Termination is not supported in Synthetics env #1937

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jul 2, 2024

What and why?

After starting dogfooding WT, we saw 300+ terminations caused by WT in s8s but those are not actually WT but normal terminations caused by https://github.com/appium/appium-xcuitest-driver/blob/main/lib/real-device.js#L216 API. This API is used by s8s for Restart Application special action.

How?

Add extra syntheticsEnvironment state variable which stores the state if the app was running in s8s or not. This value is determined based on the presence of _dd.synthetics.test_id or _dd.synthetics.result_id env vars.

I couldn't find any other information in the form of env var, args or launch args which we can use to make a decision so it not only covers s8s but also covers other UI automation frameworks.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

@ganeshnj ganeshnj marked this pull request as ready for review July 3, 2024 06:11
@ganeshnj ganeshnj requested review from a team as code owners July 3, 2024 06:11
@ganeshnj ganeshnj merged commit 6d48060 into develop Jul 3, 2024
14 checks passed
@ganeshnj ganeshnj deleted the ganeshnj/fix/wt-s8s branch July 3, 2024 08:29
@maciejburda maciejburda mentioned this pull request Jul 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants