feat: Replace use of #filePath with #fileID #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fuzzybinary
force-pushed
the
jward/RUM-5155-fileId-over-filepath
branch
2 times, most recently
from
b90ee53 to
eadf6fe
Compare
mariedm
previously approved these changes
Jul 3, 2024
maxep
previously approved these changes
Jul 3, 2024
#filePath exposes full paths of build files. Use of #fileID is encouraged by Apple both because it gives you better privacy and reduces the size of the compiled binary. refs: RUM-5155
fuzzybinary
force-pushed
the
jward/RUM-5155-fileId-over-filepath
branch
from
eadf6fe to
eed20be
Compare
ganeshnj
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
#filePath exposes full paths of build files. Use of #fileID is encouraged by Apple both because it gives you better privacy and reduces the size of the compiled binary.
refs: RUM-5155
Review checklist
Custom CI job configuration (optional)