Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make testing distributed header injection easier in Example app #1954

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jul 10, 2024

What and why?

Testing multiple header types and injection control is not one click away.

I'm not a SwiftUI expert, the MultiSelector code is inspired from https://github.com/Jeehut/MultiSelectorDemo/tree/main

How?

This code was in my stashes for some time and it makes sense to add to our manual testing to help everyone.

  • Add support injection types
  • Ability to select multiple headers
  • Print JSON response for quick verification
  • Changed default address to https://httpbin.org/get which returns back the headers which we can quickly verify.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

Custom CI job configuration (optional)

  • Run unit tests for Session Replay

@ganeshnj ganeshnj requested review from a team as code owners July 10, 2024 09:19
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@ganeshnj ganeshnj merged commit d80d1cf into develop Jul 17, 2024
15 checks passed
@ncreated ncreated mentioned this pull request Jul 25, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants