RUM-5248 feat: send memory warning as RUM error #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
changed the title
ganeshnj
force-pushed
the
ganeshnj/feat/memory-warning-errors
branch
2 times, most recently
from
eb6a253 to
cd9c78d
Compare
ganeshnj
changed the title
ganeshnj
force-pushed
the
ganeshnj/feat/memory-warning-errors
branch
from
cd9c78d to
3f527c3
Compare
ganeshnj
force-pushed
the
ganeshnj/feat/memory-warning-errors
branch
from
3f527c3 to
d03a5bf
Compare
ncreated
previously approved these changes
Jul 18, 2024
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| - [FEATURE] Enable DatadogCore, DatadogLogs and DatadogTrace to compile on watchOS platform. See [#1918][] (Thanks [@jfiser-paylocity][]) [#1946][] | |||
| - [IMPROVEMENT] Ability to clear feature data storage using `clearAllData` API. See [#1940][] | |||
| - [IMPROVEMENT] Send memory warning as RUM error. | |||
There was a problem hiding this comment.
change-request/ We're missing PR ID here, making it harder to combine release notes when shipping next release.
ganeshnj
commented
Jul 18, 2024
CHANGELOG.md
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| - [FEATURE] Enable DatadogCore, DatadogLogs and DatadogTrace to compile on watchOS platform. See [#1918][] (Thanks [@jfiser-paylocity][]) [#1946][] | |||
| - [IMPROVEMENT] Ability to clear feature data storage using `clearAllData` API. See [#1940][] | |||
| - [IMPROVEMENT] Send memory warning as RUM error. | |||
ncreated
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
memory warnings are not reported, with WT now in place these warnings can be helpful to get bigger picture and root cause the WT.
How?
Initial plan was to setup a context observer which will listen to memory warnings but the current dependency management around backtrace tracking doesn't allow generating a backtrace in DatadogContextProvider. This would have been a generic solution where any target can listen to memory warnings but had to drop this idea.
Instead, I added
MemoryWarningMonitorwhich monitors the memory warnings and reports them when they occur.Reporting part is kept outside the monitor to keep the monitor simple and testable.
Model update DataDog/rum-events-format#215
PS: I had the context observer working property basis which can be retrieved from cd9c78d if needed in future.
Review checklist
Custom CI job configuration (optional)