RUM-4709 feat: decorate network span kind as client
#1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshnj
force-pushed
the
ganeshnj/feat/client-span
branch
from
9a1781f to
783407b
Compare
mariedm
approved these changes
Jul 19, 2024
mariusc83
reviewed
Jul 19, 2024
| XCTAssertEqual( | ||
| span.tags[SpanTags.errorStack], | ||
| "Error Domain=HTTPURLResponse Code=404 \"404 not found\" UserInfo={NSLocalizedDescription=404 not found}" | ||
| ) | ||
| XCTAssertEqual(span.tags.count, 8) | ||
| XCTAssertEqual(span.tags.count, 9) |
There was a problem hiding this comment.
shouldn't this update the current tag that was internal before ? Why do we have more tags then before ? We were not sending the kind:internal before on these spans ?
There was a problem hiding this comment.
interesting enough we are not sending the kind as of now in open tracing world.
We do this in otel world.
mariusc83
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
APM needs to be able to differentiate between a client span vs other span to be able to build features on top of it.
How?
Attach
span.kindfor all network spans in Trace module.The ask is for APM spans only, not for RUM spans as they are ingested by RUM BE.
Review checklist