fix: Ensure needed attributes are sent from logs on the message bus #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Certain attributes (fingerprint and error source type) are removed as part of log processing because they are moved onto official properties of errors in logs. However, when these errors are transmitted to RUM, the properties are not replaced, which they should be, so that RUM has all of the information about the error.
fuzzybinary
force-pushed
the
jward/cp-error-attributes
branch
from
cdc9614 to
6e84165
Compare
fuzzybinary
changed the title
maxep
reviewed
Aug 20, 2024
Comment on lines
+192
to
+200
| // Add back in fingerprint and error source type | ||
| var busCombinedAttributes = combinedAttributes | ||
| if let errorSourcetype = error?.sourceType { | ||
| busCombinedAttributes[CrossPlatformAttributes.errorSourceType] = errorSourcetype | ||
| } | ||
| if let errorFingerprint = errorFingerprint { | ||
| busCombinedAttributes[Logs.Attributes.errorFingerprint] = errorFingerprint | ||
| } | ||
|
|
There was a problem hiding this comment.
/suggestion I think it would be clearer if these properties were added to ErrorMessage object, would that be possible?
There was a problem hiding this comment.
That's a much larger refactor is the issue. 😓
maxep
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Certain attributes (fingerprint and error source type) are removed as part of log processing because they are moved onto official properties of errors in logs. However, when these errors are transmitted to RUM, the properties are not replaced, which they should be, so that RUM has all of the information about the error.
Review checklist