Always assume device is online on Apple Watch #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening the PR. It's one of the considered solutions. We'll be discussing with the team if we see any blockers for disabling reachability for watchOS. |
maxep
changed the base branch from
develop
to
jfiser-paylocity/bugfix/watchos-ignore-reachability-results
maxep
approved these changes
Aug 21, 2024
|
Hey @jfiser-paylocity 👋 Thank you very much for your contribution, I'm going to merge it on a feature branch so we can perform more tests. We will ping you when it catch a release train. |
maxep
merged commit 45bdc5d
into
DataDog:jfiser-paylocity/bugfix/watchos-ignore-reachability-results
2 checks passed
3 tasks
|
Hi @jfiser-paylocity 👋 Thanks for your contribution, we just released this in version 2.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Workaround for the issue #2004.
On a real Apple Watch device,
NWPathMonitorcomponent always returns value of.unsatisfiedthat results in no logs being ever uploaded to API. As there is no straight-forward replacement for watchOS platform, this PR assumes that Apple Watch device is always online (another solution could be to implement periodic URL check in time interval).From https://developer.apple.com/documentation/Technotes/tn3135-low-level-networking-on-watchOS:
Datadog dashboard logs using the fix:
How?
This PR specifically fixes logs upload by bypassing reachability check in
DataUploadConditions.Review checklist