Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5555 Add job to build benchmarks runner #2006

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Aug 20, 2024

What and why?

Add job to build the BenchmarkTests project if any changes were applied to catch build failures in PRs.

How?

Benchmark Build:
  stage: smoke-test
  rules:
    - if: '$CI_COMMIT_BRANCH' # when on branch with following changes compared to develop
      changes:
        paths:
          - "BenchmarkTests/**/*"
        compare_to: 'develop'
  script:
    - make benchmark-build

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@maxep maxep marked this pull request as ready for review August 20, 2024 15:09
@maxep maxep requested review from a team as code owners August 20, 2024 15:09
ncreated
ncreated previously approved these changes Aug 21, 2024
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍. I left 2 feedbacks to consider.

Makefile Outdated Show resolved Hide resolved
.gitlab-ci.yml Outdated Show resolved Hide resolved
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
@maxep maxep requested a review from ncreated August 21, 2024 11:55
@maxep maxep merged commit 93c5d1e into develop Aug 26, 2024
18 checks passed
@maxep maxep deleted the maxep/RUM-5555/add-benchmark-job branch August 26, 2024 09:16
@mariedm mariedm mentioned this pull request Sep 11, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants