Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Benchmark Upload #2028

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix: Benchmark Upload #2028

merged 1 commit into from
Aug 29, 2024

Conversation

maxep
Copy link
Member

@maxep maxep commented Aug 29, 2024

What and why?

Set env DD_BENCHMARK for benchmark build

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@maxep maxep requested review from a team as code owners August 29, 2024 09:43
ncreated
ncreated approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: maxep/fix/benchmark-upload
Commit report: 0b8f312
Test service: dd-sdk-ios

✅ 0 Failed, 1866 Passed, 0 Skipped, 1m 17.09s Total Time
🔻 Test Sessions change in coverage: 4 decreased, 1 increased (+0.02%), 3 no change

🔻 Code Coverage Decreases vs Default Branch (4)

  • test DatadogRUMTests iOS 81.74% (-0.05%) - Details
  • test DatadogInternalTests iOS 79.63% (-0.02%) - Details
  • test DatadogTraceTests iOS 54.34% (-0.02%) - Details
  • test DatadogSessionReplayTests iOS 30.49% (-0.02%) - Details

@maxep maxep merged commit b2086fa into develop Aug 29, 2024
17 checks passed
@maxep maxep deleted the maxep/fix/benchmark-upload branch August 29, 2024 11:45
@mariedm mariedm mentioned this pull request Sep 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciejburda maciejburda maciejburda approved these changes

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxep @ncreated @maciejburda