feat: Improve metrics collected during benchmarks #2031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Memory and CPU metrics were only reporting the last values collected after 10 s interval. It cannot provide accurate data, instead we are now collecting metrics more frequently and report the aggregated values during push.
How?
Collect CPU usage and Memory footprint using timers configured to read values every 100 ms, then report the aggregation depending on the metric type:
Review checklist