-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-5841 feat(view-loading-api): introduce telemetry for the API and overwrite flag #2040
Conversation
c0975fa
to
8ca891a
Compare
Datadog ReportBranch report: ✅ 0 Failed, 3432 Passed, 0 Skipped, 2m 23.05s Total Time 🔻 Code Coverage Decreases vs Default Branch (12)
|
8ca891a
to
32c9725
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, especially the work on sample rate 👍. I believe the "is active" view consideration is not entirely correct in RUMViewScope
. I left comments, LMKWDYT.
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
Co-authored-by: Maciek Grzybowski <maciek.grzybowski@datadoghq.com>
What and why?
https://datadoghq.atlassian.net/wiki/spaces/RUMP/pages/3951001790/RFC+View+loading+time+manual+API
How?
overwrite
argument to the APIReview checklist