Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-5841 feat(view-loading-api): introduce telemetry for the API and overwrite flag #2040

Merged
merged 5 commits into from
Sep 11, 2024

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Sep 9, 2024

What and why?

https://datadoghq.atlassian.net/wiki/spaces/RUMP/pages/3951001790/RFC+View+loading+time+manual+API

How?

  • Integration of the telemetry events
    • happy path
    • when there is overwrite
    • when there the current view is not active
    • when there is no view scope
  • overwrite argument to the API

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@ganeshnj ganeshnj force-pushed the ganeshnj/feat/view-loading-api-tel branch from c0975fa to 8ca891a Compare September 9, 2024 13:05
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Sep 9, 2024

Datadog Report

Branch report: ganeshnj/feat/view-loading-api-tel
Commit report: 680e7f2
Test service: dd-sdk-ios

✅ 0 Failed, 3432 Passed, 0 Skipped, 2m 23.05s Total Time
🔻 Test Sessions change in coverage: 12 decreased, 2 increased

🔻 Code Coverage Decreases vs Default Branch (12)

This report shows up to 5 code coverage decreases.

  • test DatadogLogsTests tvOS 46.79% (-1.19%) - Details
  • test DatadogLogsTests iOS 46.73% (-1.19%) - Details
  • test DatadogCrashReportingTests tvOS 26.6% (-0.32%) - Details
  • test DatadogCrashReportingTests iOS 26.57% (-0.3%) - Details
  • test DatadogInternalTests iOS 79.51% (-0.14%) - Details

@ganeshnj ganeshnj force-pushed the ganeshnj/feat/view-loading-api-tel branch from 8ca891a to 32c9725 Compare September 9, 2024 13:13
@ganeshnj ganeshnj marked this pull request as ready for review September 9, 2024 14:23
@ganeshnj ganeshnj requested review from a team as code owners September 9, 2024 14:23
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, especially the work on sample rate 👍. I believe the "is active" view consideration is not entirely correct in RUMViewScope. I left comments, LMKWDYT.

DatadogInternal/Sources/Telemetry/Telemetry.swift Outdated Show resolved Hide resolved
DatadogInternal/Sources/Telemetry/Telemetry.swift Outdated Show resolved Hide resolved
DatadogRUM/Sources/RUMMonitor/Scopes/RUMViewScope.swift Outdated Show resolved Hide resolved
DatadogRUM/Sources/RUMMonitor/Scopes/RUMViewScope.swift Outdated Show resolved Hide resolved
DatadogRUM/Sources/RUMMonitor/Scopes/RUMSessionScope.swift Outdated Show resolved Hide resolved
ganeshnj and others added 4 commits September 10, 2024 11:29
@ganeshnj ganeshnj requested a review from ncreated September 10, 2024 15:30
@ganeshnj ganeshnj merged commit 4339f23 into develop Sep 11, 2024
15 checks passed
@ncreated ncreated mentioned this pull request Sep 11, 2024
3 tasks
@maciejburda maciejburda mentioned this pull request Sep 24, 2024
3 tasks
@maxep maxep deleted the ganeshnj/feat/view-loading-api-tel branch September 26, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants