Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-6395: Add internal logging/telemetry APIs to ObjC #2073

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Oct 3, 2024

What and why?

This PR adds simple APIs to do SDK logging/telemetry from Objective-C side.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes

@0xnm 0xnm requested review from a team as code owners October 3, 2024 10:51
@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: nogorodnikov/rum-6395/add-internal-logging-telemetry-apis-to-objc
Commit report: ed023e3
Test service: dd-sdk-ios

✅ 0 Failed, 3479 Passed, 0 Skipped, 2m 21.5s Total Time
🔻 Test Sessions change in coverage: 2 decreased, 5 increased, 7 no change

🔻 Code Coverage Decreases vs Default Branch (2)

  • test DatadogCoreTests tvOS 78.53% (-0.16%) - Details
  • test DatadogTraceTests iOS 54.22% (-0.05%) - Details

@0xnm 0xnm merged commit c5ca5bb into develop Oct 4, 2024
16 checks passed
@maxep maxep mentioned this pull request Oct 24, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants