-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUMM-110 Send single message to Datadog #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The size of this PR comes mainly from the amount of mocks I had to configure for unit tests 🙄 🙌 . I will aim for keeping next PRs smaller thanks to the foundations I set up here. |
mariusc83
reviewed
Dec 16, 2019
mariusc83
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up component related to logs upload. From now, it is possible to upload single log after calling:
on the
Logger
component.What's done?
It introduces simple architecture which will be later evolved. On top, there are two packages:
Logs
,Network
.Network
contains only things related to HTTP communication, withHTTPClient
being the main component.Logs
package adds SDK logic-related stuff, withLog
model,LogsUploader
(that usesHTTPClient
) andLogsUploadRequestEncoder
for request body encoding.This architecture follows some of the logic-separation principles from Android SDK ⭐️ project.
What will come in other JIRAs?
This code is not yet covering important things decoupled to other JIRAs: