Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-110 Send single message to Datadog #3

Merged
merged 8 commits into from
Dec 17, 2019

Conversation

ncreated
Copy link
Member

This PR sets up component related to logs upload. From now, it is possible to upload single log after calling:

logger.info("Test message from ios-app-example")

on the Logger component.

What's done?

It introduces simple architecture which will be later evolved. On top, there are two packages:

  • Logs,
  • Network.

Network contains only things related to HTTP communication, with HTTPClient being the main component.

Logs package adds SDK logic-related stuff, with Log model, LogsUploader (that uses HTTPClient) and LogsUploadRequestEncoder for request body encoding.

This architecture follows some of the logic-separation principles from Android SDK ⭐️ project.

What will come in other JIRAs?

This code is not yet covering important things decoupled to other JIRAs:

  • logs persistence;
  • logs batching;
  • threading.

@ncreated ncreated requested a review from a team December 16, 2019 09:46
@ncreated ncreated self-assigned this Dec 16, 2019
@ncreated
Copy link
Member Author

The size of this PR comes mainly from the amount of mocks I had to configure for unit tests 🙄 🙌 . I will aim for keeping next PRs smaller thanks to the foundations I set up here.

@ncreated ncreated merged commit 391a969 into master Dec 17, 2019
@ncreated ncreated deleted the ncreated/RUMM-110-send-single-message branch December 17, 2019 08:46
alai97 added a commit that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants