RUMM-655 NTP time sync - rebased #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog: 1/ Add `Kronos.framework` to Datadog > Build Phases > Link Binary With Libraries. 2/ Add Datadog > Build Settings > Frameworks Search Path: `$(SRCROOT)/../Carthage/Build/iOS` Example: 1/ Add `Kronos.framework` to Example > Frameworks, Libraries and Embedded Content. 2/ Add Example > Build Settings > Frameworks Search Path: `$(SRCROOT)/../Carthage/Build/iOS` DatadogIntegrationTests: 1/ Add 'Copy Files' build phase, coping `Kronos.framework` into `Frameworks` folder Also, for all targets: - Exclude arm64 architecture for iOS Simulator builds (through `Base.xcconfig`)
buranmert
reviewed
Dec 1, 2020
buranmert
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
⚙️ This PR merges the stabilisation branch of NTP sync feature (delivered in #318 and #321) to
masterbranch.How?
Just merges + rebasing + renaming from
DateCorrectiontoDateCorrectoras discussed on Slack.Review checklist