Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-917 Fix Objc API visibility in RUMMonitor #359

Merged
merged 1 commit into from
Jan 6, 2021
+2 −3
Merged

RUMM-917 Fix Objc API visibility in RUMMonitor #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Sources/DatadogObjc/RUMMonitor+objc.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,9 @@ public class DDRUMMonitor: NSObject {
public func stopResourceLoading(
resourceKey: String,
response: URLResponse,
size: Int64?,
attributes: [String: Any]
) {
swiftRUMMonitor.stopResourceLoading(resourceKey: resourceKey, response: response, size: size, attributes: castAttributesToSwift(attributes))
swiftRUMMonitor.stopResourceLoading(resourceKey: resourceKey, response: response, attributes: castAttributesToSwift(attributes))
}

public func stopResourceLoadingWithError(
Expand Down
2 changes: 1 addition & 1 deletion Tests/DatadogTests/DatadogObjc/DDRUMMonitorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class DDRUMMonitorTests: XCTestCase {
),
attributes: ["event-attribute2": "foo2"]
)
objcRUMMonitor.stopResourceLoading(resourceKey: "/resource1", response: .mockAny(), size: 42, attributes: ["event-attribute3": "foo3"])
objcRUMMonitor.stopResourceLoading(resourceKey: "/resource1", response: .mockAny(), attributes: ["event-attribute3": "foo3"])

let rumEventMatchers = try RUMFeature.waitAndReturnRUMEventMatchers(count: 4)

Expand Down