RUMM-1160 Static pod support #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buranmert
force-pushed
the
buranmert/RUMM-1160-support-static-pod
branch
from
eb13532 to
65d86fc
Compare
buranmert
force-pushed
the
buranmert/RUMM-1160-support-static-pod
branch
from
65d86fc to
fafc060
Compare
|
✅ CI passed with |
buranmert
force-pushed
the
buranmert/RUMM-1160-support-static-pod
branch
from
5d85db7 to
9f9584b
Compare
ncreated
requested changes
Apr 8, 2021
Package.resolved
Outdated
| @@ -0,0 +1,25 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should be git-ignored 🧽
Those methods renamed to `__dd_private_MethodName` to discourage users
ncreated
approved these changes
Apr 9, 2021
buranmert
added a commit
that referenced
this pull request
Apr 12, 2021
…ic-pod RUMM-1160 Static pod support
buranmert
added a commit
that referenced
this pull request
Apr 12, 2021
…ic-pod RUMM-1160 Static pod support
ncreated
pushed a commit
that referenced
this pull request
Apr 13, 2021
…ic-pod (cherry picked from commit af85391)
ncreated
pushed a commit
that referenced
this pull request
Apr 13, 2021
…ic-pod (cherry picked from commit af85391)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
DatadogSDK.podspecrequires!use_frameworksin client'sPodfileLack of it results in error at
pod installHow?: A proposal
For cocoapods and carthage, I can mix Swift and ObjC by importing ObjC headers in framework's umbrella header as Apple suggests
For Swift Package Manager, this is not possible as mixed targets are not supported.
To solve this, I pass
SPM_BUILDflag fromPackage.swiftwhere we create_Datadog_Privatetarget.Now I can
#if SPM_BUILD import _Datadog_Private #endifin the source code.Review checklist