Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-1434 read resource span_id and trace_id from attributes #527

Merged
merged 1 commit into from
Jun 30, 2021
Merged

RUMM-1434 read resource span_id and trace_id from attributes #527

merged 1 commit into from
Jun 30, 2021

Conversation

xgouchet
Copy link
Member

What and why?

Cross platform sdks will generate the resource's span_id and trace_id on their side and forward the attributes as _dd.span_id and _dd.trace_id respectively. This PR reads those value and store them in the relevant place.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@xgouchet xgouchet requested a review from a team as a code owner June 29, 2021 12:58
ncreated
ncreated approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ 👌

@xgouchet xgouchet merged commit aeca66b into master Jun 30, 2021
@xgouchet xgouchet deleted the xgouchet/RUMM-1434/support_bridge_traces branch June 30, 2021 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncreated ncreated ncreated approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xgouchet @ncreated