RUMM-1467 Update dogfooding script for recent changes in other repos #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncreated
commented
Jul 1, 2021
Comment on lines
+130
to
+131
| '.package.resolved', | ||
| 'DatadogApp.xcworkspace/xcshareddata/swiftpm/Package.resolved' |
There was a problem hiding this comment.
💡 Two package resolved seem redundant (they are equal), but solving this is beyond the scope of this RUMM-1467.
xgouchet
approved these changes
Jul 1, 2021
ncreated
deleted the
ncreated/RUMM-1467-update-dogfooding-script-with-new-path
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
⚙️ This PR updates dogfooding script for recent changes made in Datadog iOS app repo. Now the repo uses code-generated
.package.resolvedfile, instead of one managed by Xcode.How?
Just changed the
pathslogic indogfooding.py. Now it is able to modify multiplePackage.resolvedfiles as that's the setup currently used in mobile app repo.Review checklist