RUMM-1467 Remove deprecation warnings when compiling the SDK code #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
🧽 This PR cleans up compiler warnings which pop up when compiling the SDK:
These warnings appear to any user linking the SDK to their project. Their presence is misleading - the user is not using any deprecated API, instead we do it internally in the SDK code. Because the user can't do anything to dismiss it, I'm fixing it in this PR by removing deprecation annotation in these APIs. This operation is safe as explained below.
How?
These warnings were introduced in #523 by marking legacy cases as deprecated in 3 enums:
This isn't required, as those endpoints can only be used in these 3 legacy APIs which (if called) will already emit the deprecation warning:
All these APIs are already replaced with a single
set(endpoint:)
which receivesDatadogEndpoint
enum.Review checklist