Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update License to be recognised by Github #610

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Update License to be recognised by Github #610

merged 1 commit into from
Sep 27, 2021

Conversation

xgouchet
Copy link
Member

What and why?

For now the License is not recognised by Github License detection, nor the Swift Package Index page

@xgouchet xgouchet self-assigned this Sep 27, 2021
@xgouchet xgouchet requested a review from a team as a code owner September 27, 2021 08:48
ncreated
ncreated approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the issue exactly? Does Swift Package Index search for a license text match and with those changes we make it work?

@xgouchet
Copy link
Member Author

@ncreated SPI actually relies on Github's detection, and Github needs and exact match to identify the license

@xgouchet xgouchet merged commit f306e7b into master Sep 27, 2021
@xgouchet xgouchet deleted the xgouchet/license branch September 12, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxep maxep maxep approved these changes

@ncreated ncreated ncreated approved these changes

@buranmert buranmert buranmert approved these changes

Assignees

@xgouchet xgouchet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xgouchet @buranmert @ncreated @maxep