Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-1091 Harmonize code snippet in documentation #611

Merged
merged 2 commits into from
Sep 28, 2021
Merged

RUMM-1091 Harmonize code snippet in documentation #611

merged 2 commits into from
Sep 28, 2021

Conversation

maxep
Copy link
Member

@maxep maxep commented Sep 27, 2021

What and why?

Update code snippets in doc and fix few attributes keys.

@maxep maxep requested review from a team as code owners September 27, 2021 16:02
ncreated
ncreated approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@ncreated ncreated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@maxep maxep merged commit 17fc5da into master Sep 28, 2021
@maxep maxep deleted the maxep/RUMM-1092/update-doc-code-snippet branch September 28, 2021 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayayarai kayayarai kayayarai approved these changes

@ncreated ncreated ncreated approved these changes

@buranmert buranmert buranmert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maxep @buranmert @ncreated @kayayarai