RUMM-1377 Add E2E tests for Tracing APIs #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame in `$monitor_name` as this is no longer true in some Tracing monitors.
ncreated
commented
Sep 29, 2021
Comment on lines
+70
to
+77
| /// - data monitor: (it uses `ios_trace_span_set_baggage_item` metric defined in "APM > Generate Metrics > Custom Span Metrics") | ||
| /// ```apm | ||
| /// $feature = trace | ||
| /// $monitor_id = trace_span_set_baggage_item_data | ||
| /// $monitor_name = "[RUM] [iOS] Nightly - trace_span_set_baggage_item: number of hits is below expected value" | ||
| /// $monitor_query = "sum(last_1d):avg:ios_trace_span_set_baggage_item.hits_with_proper_payload{*}.as_count() < 1" | ||
| /// $monitor_threshold = 1 | ||
| /// ``` |
There was a problem hiding this comment.
This kind of monitors require manual management of custom span metric generated at ingestion
This can't be automated and this is the only way possible if we want to make monitor assertions on span tags.
buranmert
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds E2E tests and their monitor definitions for Tracing product.
How?
Added tests with their monitors (
terraform planworks fine). I haven't yet updated monitors in Mobile Integration org - that needs to be done after merge otherwise they will have no data.I also added two changes to E2E tests linter:
$featurevariable is one of allowed values (core,logs,trace,rum,crash),$monitor_querycontains the test method name (the way we set up some monitors was not compatible with this rule).Review checklist