RUMM-1200 Remove Carthage workaround for missing arm64 slice in PLCR's xcframework
#618
Conversation
| // To build only active architecture for all configurations. This gives us ~10% build time gain\n | ||
| // in targets which do not use 'Debug' configuration.\n | ||
| ONLY_ACTIVE_ARCH = YES\n |
There was a problem hiding this comment.
I did this measurement in DatadogIntegrationTests (it doesn't use Debug configuration):
- with
ONLY_ACTIVE_ARCH = YES: 65s, 65s, 75s - without
ONLY_ACTIVE_ARCH = YES: 72s, 81s, 77s
It is justified to have higher times when building all architectures, as produced artifacts contain more slices, e.g.:
❯ lipo -info /Users/.../Release-iphonesimulator/Datadog.framework/Datadog
Architectures in the fat file: /.../Release-iphonesimulator/Datadog.framework/Datadog are: x86_64 arm64
vs:
❯ lipo -info /Users/.../Release-iphonesimulator/Datadog.framework/Datadog
Architectures in the fat file: /.../Release-iphonesimulator/Datadog.framework/Datadog are: x86_64
| // Note: this is only problematic when `carthage update --use-xcframeworks` builds `CrashReporter.xcframework` from source | ||
| // and should not be an issue once pre-build xcframeworks support is added to Carthage: https://github.com/Carthage/Carthage/pull/3123 | ||
| // However, carthage always falls back to build from source if it can't download pre-build binaries, so this adjustment | ||
| // will be still required. |
There was a problem hiding this comment.
I'm not really sure if this is correct and/or helps with anything. Even if falling back to build from source, as we were only allowing ARCHS[sdk=iphonesimulator*] = x86_64 in this patch, that would fail to compile for simulator on Apple Silicon. I think the strategy of not overriding ARCHS in such case is safer. As we don't need this patch anymore for our own development, I remove it entirely.
There was a problem hiding this comment.
Note: I only reffer to the note on posibility to remove this patch. The patch was valid, but we don't need it anymore.
ncreated
force-pushed
the
ncreated/RUMM-1200-remove-workaround-for-carthage-build
branch
from
09581c4 to
0b21ab4
Compare
ncreated
deleted the
ncreated/RUMM-1200-remove-workaround-for-carthage-build
branch
What and why?
📦 This PR removes workaround added in early development of
DatadogCrashReportingwhenPLCR'sxcframework (1.8.0) was missing thearm64-simulatorslice.The recent version of
PLCR'sxcframework (1.10.0) includes the missing slice, so this workaround is not needed anymore. It also means that now all targets inDatadog.xcworkspacecan be compiled on Apple Silicon.How?
Made necessary updates in
xcconfigs.Review checklist