RUMM-1394 Add more verbosity to flaky test errors #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `URLSessionSwizzlerTests` and `DDURLSessionDelegateTests`
ncreated
commented
Oct 1, 2021
| @@ -94,26 +94,28 @@ class DDURLSessionDelegateTests: XCTestCase { | |||
|
|
|||
| // When | |||
| let taskWithURL = session.dataTask(with: URL.mockAny()) | |||
| taskWithURL.taskDescription = "taskWithURL" | |||
There was a problem hiding this comment.
As (in flaky scenario) we receive some other task than we expect, here I tag each task with a custom description, so we can see it in the error (expected vs actual taskDescription).
buranmert
approved these changes
Oct 4, 2021
maxep
approved these changes
Oct 4, 2021
ncreated
deleted the
ncreated/RUMM-1394-add-more-information-to-flaky-test-errors
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
📦 This PR adds a bit more verbosity to errors which we capture in flaky tests.
Looking at last
7d, we got 11 failures in nightly tests:Unfortunately, the error messages are not handy in troubleshooting:
As I couldn't reproduce these failures locally (in exactly the same OS + simulator setup and with
dd-swift-testinginstrumentation enabled), I propose to first add more verbosity in this PR, and collect more data in CI App.How?
I improved the way we compare two task instances. Instead of:
now it uses a helper method:
which dumps additional information about the
lhsandrhstasks if they are not identical, e.g:Review checklist