Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Debug webview" screen to Example app #628

Merged

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Oct 8, 2021

What and why?

🐶 This PR adds debug screen to the Example app, where we can test webviews. Native integration is yet to be added, but this will unlock other teams on testing dd-sdk-ios and webviews.

Screenshot 2021-10-08 at 13 04 43Screenshot 2021-10-08 at 12 56 02Screenshot 2021-10-08 at 12 55 59

How?

Added menu option and basic "webview launch" screen with minimal setup:

  • starting a native RUM Session before opening webview (this can be later used for testing session propagation),
  • starting a webview with custom URL (Datadog website by default).

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ncreated ncreated self-assigned this Oct 8, 2021
@ncreated ncreated requested a review from a team as a code owner October 8, 2021 11:06
@ncreated ncreated merged commit fcbacd6 into master Oct 8, 2021
@ncreated ncreated deleted the ncreated/add-option-to-debug-webviews-for-synthetics branch October 8, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants