Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RUMM-346 Add Cocoa Pods dependency manager test #66

Merged
merged 1 commit into from
Apr 6, 2020
Merged

RUMM-346 Add Cocoa Pods dependency manager test #66

merged 1 commit into from
Apr 6, 2020

Conversation

ncreated
Copy link
Member

@ncreated ncreated commented Apr 2, 2020

What and why?

📦 This PR adds Cocoa Pods installation test.

How?

make test-cocoapods sources Podfile.src by injecting current git branch name, then pod update is called. After this, Bitrise runs UITests for this CPProject.xcworkspace.

I also update SPMProject to run UITests from bitrise.yml instead of xcodebuild in Makefile. This has few benefits:

  • cleaner build log on Bitrise thanks to xcpretty;
  • SPMProject-ui-test artifact is exported on Bitrise;
  • build-related logic is centralized in single place (bitrise.yml).

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference

@ncreated
RUMM-346 Add Cocoapods dependency manager test
3d65686 
and disable CP example project on CI as we're going to update it's structure very soon in RUMM-334.
@ncreated ncreated requested a review from buranmert April 2, 2020 17:01
@ncreated ncreated requested a review from a team as a code owner April 2, 2020 17:01
@ncreated ncreated self-assigned this Apr 2, 2020
buranmert
buranmert approved these changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@buranmert buranmert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ncreated ncreated merged commit 4db2dd9 into master Apr 6, 2020
@buranmert buranmert deleted the ncreated/RUMM-346-add-cocoapods-test branch April 24, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buranmert buranmert buranmert approved these changes

Assignees

@ncreated ncreated

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ncreated @buranmert